Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependencies #9452

Merged
merged 2 commits into from
Jan 25, 2024
Merged

update dependencies #9452

merged 2 commits into from
Jan 25, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jan 25, 2024

resolves #8790

Problem

We had to hard pin a type check because of dependency resolution

Solution

Stop pinning it
add back requests dependency because core uses it
remove other type checkers we no longer need

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jan 25, 2024
@emmyoop emmyoop added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Jan 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bdcf264) 87.84% compared to head (169ca7b) 87.92%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9452      +/-   ##
==========================================
+ Coverage   87.84%   87.92%   +0.08%     
==========================================
  Files         160      160              
  Lines       21934    21934              
==========================================
+ Hits        19267    19285      +18     
+ Misses       2667     2649      -18
Flag Coverage Δ
integration 85.46% <ø> (+0.15%) ⬆️
unit 62.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cla-bot cla-bot bot added the cla:yes label Jan 25, 2024
@emmyoop emmyoop mentioned this pull request Jan 25, 2024
Merged
5 tasks
@emmyoop emmyoop marked this pull request as ready for review January 25, 2024 19:29
@emmyoop emmyoop requested a review from a team as a code owner January 25, 2024 19:29
ChenyuLInx
ChenyuLInx approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks！！

@emmyoop emmyoop merged commit 6663846 into main Jan 25, 2024
55 checks passed
@emmyoop emmyoop deleted the er/fix-dependency branch January 25, 2024 19:39
@tlento tlento mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelleArk MichelleArk MichelleArk approved these changes

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-3190] Pinning detective work
3 participants
@emmyoop @MichelleArk @ChenyuLInx